Skip to content

feat(obs): export internal logs with otlp exporter#6142

Merged
guilload merged 6 commits intoquickwit-oss:mainfrom
Totodore:feat-obs-export-logs-as-otel
Mar 9, 2026
Merged

feat(obs): export internal logs with otlp exporter#6142
guilload merged 6 commits intoquickwit-oss:mainfrom
Totodore:feat-obs-export-logs-as-otel

Conversation

@Totodore
Copy link
Contributor

@Totodore Totodore commented Feb 4, 2026

Description

Currently quickwit only export its traces, this change also export internal logs if the QW_ENABLE_OPENTELEMETRY_OTLP_EXPORTER is set to true.

This is particularly important in a production env when we want to have structured logs to monitor quickwit and find root cause for quickwit internal errors.

How was this PR tested?

  • Tested in local with dog fooding, the instance eat its logs and put it in otel-logs-v0_9 as expected.

Side note

We may want to put another env config to disable this behavior by default.
We may also want to configure custom batching behavior according to the log volume (something that I'm not particularly aware of).

Copy link
Collaborator

@ncoiffier-celonis ncoiffier-celonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to see this PR merged.

Copy link
Member

@guilload guilload left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, ty @Totodore! Ping me when you have fixed the typo and rebased so I can approve the workflow run and merge.

@Totodore
Copy link
Contributor Author

Totodore commented Mar 5, 2026

@guilload done!

@Totodore Totodore requested a review from guilload March 5, 2026 08:55
@guilload
Copy link
Member

guilload commented Mar 5, 2026

You're missing this:

dd-rust-license-tool --config quickwit/license-tool.toml --manifest-path quickwit/Cargo.toml write

https://github.com/DataDog/rust-license-tool

See also CONTRIBUTING.md.

@Totodore
Copy link
Contributor Author

Totodore commented Mar 7, 2026

@guilload done

@guilload guilload merged commit e86f4fb into quickwit-oss:main Mar 9, 2026
4 checks passed
@Totodore Totodore deleted the feat-obs-export-logs-as-otel branch March 9, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants